Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: add a test for checking AKS upstream #939

Merged
merged 34 commits into from
Oct 29, 2024
Merged

e2e: add a test for checking AKS upstream #939

merged 34 commits into from
Oct 29, 2024

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Oct 17, 2024 •
edited
Loading

Add a test that checks if something in azure upstream is broken by deploying a simple container with the kata-cc-isolation runtime class. You can view a successful workflow run here.

@miampf miampf added the no changelog PRs not listed in the release notes label Oct 17, 2024
@miampf miampf force-pushed the miampf/e2e/kata-isolation-cc-test branch 2 times, most recently from b8059ee to 8fc4293 Compare October 17, 2024 15:08
@miampf miampf marked this pull request as ready for review October 17, 2024 15:08
@miampf miampf marked this pull request as draft October 17, 2024 15:08
@miampf miampf marked this pull request as ready for review October 17, 2024 15:09
@miampf
Copy link
Contributor Author

miampf commented Oct 17, 2024

Note that the boilerplate of manually adding the confcom extension to the nixpkgs overlay should be removed before merging. This is currently not possible as the azure-cli package in nixpkgs-unstable is broken.

Freax13
Freax13 reviewed Oct 18, 2024
View reviewed changes
.github/workflows/e2e_aks_runtime.yml Outdated Show resolved Hide resolved
e2e/aks-runtime/aks_runtime_test.go Outdated Show resolved Hide resolved
e2e/aks-runtime/aks_runtime_test.go Outdated Show resolved Hide resolved
@miampf miampf force-pushed the miampf/e2e/kata-isolation-cc-test branch from 54b0fb1 to 9985321 Compare October 22, 2024 08:58
@miampf miampf force-pushed the miampf/e2e/kata-isolation-cc-test branch 5 times, most recently from faad72e to 71b3501 Compare October 24, 2024 13:03
@miampf
Copy link
Contributor Author

miampf commented Oct 24, 2024 •
edited
Loading

Due to az installed via nix being a pinned version, I've added an option to not run an E2E test in a nix environment and turned it on for the aks-runtime test. A new successful run with this configuration can be viewed here

@miampf miampf requested review from burgerdev and Freax13 October 24, 2024 13:15
burgerdev
burgerdev approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few nits

.github/workflows/e2e_aks_runtime.yml Outdated Show resolved Hide resolved
.github/workflows/e2e_aks_runtime.yml Outdated Show resolved Hide resolved
e2e/aks-runtime/aks_runtime_test.go Outdated Show resolved Hide resolved
e2e/aks-runtime/aks_runtime_test.go Outdated Show resolved Hide resolved
e2e/aks-runtime/aks_runtime_test.go Show resolved Hide resolved
e2e/internal/az/confcom.go Outdated Show resolved Hide resolved
Freax13
Freax13 reviewed Oct 25, 2024
View reviewed changes
.github/workflows/e2e_aks_runtime.yml Outdated Show resolved Hide resolved
packages/by-name/contrast/package.nix Outdated Show resolved Hide resolved
@miampf miampf force-pushed the miampf/e2e/kata-isolation-cc-test branch from b06a87e to 9edd55a Compare October 29, 2024 10:39
@Freax13 Freax13 self-requested a review October 29, 2024 11:00
@miampf
Copy link
Contributor Author

miampf commented Oct 29, 2024

New successful run here

@miampf miampf requested a review from burgerdev October 29, 2024 11:59
miampf added 17 commits October 29, 2024 15:29
@miampf miampf force-pushed the miampf/e2e/kata-isolation-cc-test branch from bdd1fc3 to de49a8e Compare October 29, 2024 14:29
burgerdev
burgerdev approved these changes Oct 29, 2024
View reviewed changes
.github/workflows/e2e_aks_runtime.yml Outdated Show resolved Hide resolved
.github/workflows/e2e_aks_runtime.yml Outdated Show resolved Hide resolved
.github/workflows/e2e_aks_runtime.yml Show resolved Hide resolved
e2e/aks-runtime/aks_runtime_test.go Outdated Show resolved Hide resolved
e2e/internal/az/aks.go Show resolved Hide resolved
Freax13
Freax13 reviewed Oct 29, 2024
View reviewed changes
.github/workflows/e2e_aks_runtime.yml Outdated Show resolved Hide resolved
packages/by-name/contrast/package.nix Outdated Show resolved Hide resolved
packages/by-name/contrast/package.nix Outdated Show resolved Hide resolved
burgerdev
burgerdev approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge it :)

@miampf miampf merged commit bae04c4 into main Oct 29, 2024
11 checks passed
@miampf miampf deleted the miampf/e2e/kata-isolation-cc-test branch October 29, 2024 16:55
katexochen
katexochen reviewed Oct 29, 2024
View reviewed changes
overlays/nixpkgs.nix
Comment on lines +70 to +72
withExtensions = with final.azure-cli.extensions; [
aks-preview
confcom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere in the end? Looks like we are installing the cli via apt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen left review comments

@Freax13 Freax13 Freax13 approved these changes

@burgerdev burgerdev burgerdev approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miampf @burgerdev @Freax13 @katexochen