Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: better default values #945

Merged
merged 1 commit into from
Oct 29, 2024
Merged

infra: better default values #945

merged 1 commit into from
Oct 29, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Oct 21, 2024

Improve the default values in the deployment a little:

  • Free-tier clusters are not always available, so this makes the deployment default to using a standard-tier cluster.
  • GPU instances (which are the only ones we provide a working image for at the moment) are unavailable in germanywestcentral. Therefore, default to a GPU-enabled region here. This should not have any disadvantages compared to germanywestcentral for non-GPU use.

@msanft msanft requested a review from katexochen as a code owner October 21, 2024 06:35
@msanft msanft added the no changelog PRs not listed in the release notes label Oct 21, 2024
@msanft msanft force-pushed the msanft/infra/better-defaults branch from 69f3877 to 94a3741 Compare October 21, 2024 09:20
@msanft msanft requested review from burgerdev and Freax13 October 21, 2024 09:20
@msanft msanft force-pushed the msanft/infra/better-defaults branch 2 times, most recently from 5ecea52 to 440af06 Compare October 21, 2024 09:45
burgerdev
burgerdev requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard tier almost doubles the price of a one-node cluster. Is there no overlap between regions that have GPUs and regions that have free-tier AKS? Can we at least make this configurable, so that peerpod development without need for GPU can choose?

@msanft msanft force-pushed the msanft/infra/better-defaults branch from 440af06 to 111e7b1 Compare October 28, 2024 08:58
@msanft msanft requested a review from burgerdev October 28, 2024 10:09
@msanft
infra/azure-peerpods: create standard tier cluster by default
9d1dab0 
Free-tier clusters are not always available, so this makes the deployment default to using a standard-tier cluster.
@msanft msanft force-pushed the msanft/infra/better-defaults branch from 111e7b1 to 9d1dab0 Compare October 28, 2024 10:10
burgerdev
burgerdev approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

infra/azure-peerpods/vars.tf
@@ -13,3 +13,8 @@ variable "subscription_id" {
variable "image_id" {
type = string
}

variable "cluster_type" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster_sku_tier might be a better var name.

@msanft msanft merged commit 821924f into main Oct 29, 2024
9 checks passed
@msanft msanft deleted the msanft/infra/better-defaults branch October 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freax13 Freax13 Freax13 approved these changes

@burgerdev burgerdev burgerdev approved these changes

@katexochen katexochen Awaiting requested review from katexochen

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msanft @burgerdev @Freax13