-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: fix runtime reproducibility test and also check kata.contrast-node-installer-image
#960
Conversation
60107d4
to
f5d6e63
Compare
fc0bf1c
to
a41cce6
Compare
@miampf could you separate the fix and the additional test into two distinct commits please (and rebase-merge later)? |
It will take some time until merge anyways since the test is not failing as expected. When it comes to merging it I will keep this in mind tho :) |
70a2682
to
a41cce6
Compare
The test does fail if different values are detected (look here, I just randomly generated strings instead of using a hash), however, it does not fail when comparing the images digests (look here), reason being that they are equal. @katexochen, since reproducibility should be broken but the digests are the same, should we compare something other than the image digest? If yes, what do you think would be a good option? |
a41cce6
to
36de831
Compare
It's fine, the current reproducibility issues are really hard to reproduce, it would be to much work to detect that in a ci job. The test succeeds as this reproduces between the two machine, so there is no blocker to merge this from my perspective. |
36de831
to
21f5a5a
Compare
21f5a5a
to
d0a469c
Compare
Follow up of #947. New successful run can be found here.