erofs: improve reproducibility of podvm images #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this was working in v1.7.1, there was a refactoring in https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?id=0da388cfdc9dcb952c01b0755ab8a1d6d59a5312 causing the inode numbering to depend on the host fs. This patch adds sorting to provide a stable ordering when calling readdir. Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
msanft
approved these changes
Oct 30, 2024
Closed
Freax13
suggested changes
Oct 30, 2024
There was a problem hiding this comment.
:(
[freax13@laptop:~/code/contrast-3]$ sha256sum result/image-podvm-gpu_1-rc1.raw
497894fa4b8d8eb24b6bc91db3c0010843238789f5efc5c73cd8ab5d46f056cf result/image-podvm-gpu_1-rc1.raw
[freax13@laptop:~/code/contrast-3]$ realpath result/image-podvm-gpu_1-rc1.raw
/nix/store/75i3pwrp4yf8vf0lh5d241z3b4fkdm5k-image-podvm-gpu-1-rc1/image-podvm-gpu_1-rc1.raw
|
Nvm, I can't read, I didn't run |
burgerdev
approved these changes
Oct 30, 2024
Freax13
approved these changes
Oct 30, 2024
|
Should we enable auto-optimise for our CI builders? |
|
Still not reproducible for @3u13r , but I'd say it's a step in the right direction so we merge anyway? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify reproducibility on your local system with
If you face reproducibility issues, try to optimise your nix store, as the issue might be related to hard linking. There is a (soft) improvement on that already in unstable (but we are currently a bit behind), but it is also a topic of future work.