Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upload peerpod images during release #972

Closed
wants to merge 4 commits into from
Closed

ci: upload peerpod images during release #972

wants to merge 4 commits into from

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Nov 4, 2024

No description provided.

@Freax13 Freax13 requested a review from katexochen as a code owner November 4, 2024 11:47
@Freax13 Freax13 added the no changelog PRs not listed in the release notes label Nov 4, 2024
@Freax13 Freax13 force-pushed the tom/peerpods-release-upload branch from 945807b to 4b85507 Compare November 4, 2024 13:16
@Freax13 Freax13 requested a review from fidencio November 4, 2024 13:21
fidencio
fidencio reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Freax13, just one more question from me.

packages/scripts.nix Outdated Show resolved Hide resolved
@Freax13 Freax13 force-pushed the tom/peerpods-release-upload branch from 4b85507 to 4cf831b Compare November 4, 2024 13:53
@Freax13 Freax13 requested a review from fidencio November 4, 2024 13:53
@fidencio
Copy link
Contributor

fidencio commented Nov 4, 2024

lgtm, thanks @Freax13!

@Freax13
Copy link
Contributor Author

Freax13 commented Nov 4, 2024

Upload seems to have worked on a test run: https://github.com/edgelesssys/contrast/actions/runs/11665650905/job/32478830325

@katexochen katexochen requested a review from 3u13r November 11, 2024 14:48
3u13r
3u13r approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that the release workflow overrides an existing images as already done for e.g. the container images.
LGTM

@3u13r 3u13r added the blocked There is something blocking the progress on this one label Nov 18, 2024
@3u13r
Copy link
Member

3u13r commented Nov 18, 2024

As discussed with @katexochen, blocked until at least #992 is merged.

@3u13r 3u13r closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3u13r 3u13r 3u13r approved these changes

@fidencio fidencio fidencio approved these changes

@katexochen katexochen Awaiting requested review from katexochen katexochen is a code owner

Assignees

@3u13r 3u13r

Labels
blocked There is something blocking the progress on this one no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Freax13 @fidencio @3u13r