e2e: improve log collection #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miampf
force-pushed
the
miampf/also-collect-init-container-logs
branch
from
e46a38c to
d6b9c9c
Compare
|
E2E runs that use the new log collection: https://github.com/edgelesssys/contrast/actions/runs/11799318639?pr=985 |
burgerdev
reviewed
Nov 13, 2024
miampf
force-pushed
the
miampf/also-collect-init-container-logs
branch
4 times, most recently
from
62bfc50 to
6a6b45c
Compare
|
Run with new script structure and working log collection: https://github.com/edgelesssys/contrast/actions/runs/11912439438?pr=985 |
burgerdev
approved these changes
Nov 21, 2024
miampf
force-pushed
the
miampf/also-collect-init-container-logs
branch
from
6a6b45c to
fe1570d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the log collection to also collect init container logs. This is done by adding a
log-collectordaemon set to every e2e cluster that saves logs from the host node which then are downloaded to the local machine through the updatedget-logsscript.