fix: update edgeless blog link #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Weiße <[email protected]>
✅ Deploy Preview for marblerun-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
thomasten
requested changes
Nov 13, 2023
| @@ -11,7 +11,7 @@ This guide walks you through setting up MarbleRun for your on-premises deploymen | |||
| To deploy MarbleRun with Intel SGX, the machine or VM has to support Intel SGX. | |||
| Particularly, MarbleRun requires support for the SGX Data Center Attestation Primitives (DCAP). | |||
| You can verify [if your CPU supports DCAP](https://www.intel.com/content/www/us/en/support/articles/000057420/software/intel-security-products.html). | |||
| For more information, read this article on [detecting Intel Software Guard Extensions](https://software.intel.com/content/www/us/en/develop/articles/properly-detecting-intel-software-guard-extensions-in-your-applications.html) in your applications. | |||
| For more information, read this article on [detecting Intel Software Guard Extensions](https://www.intel.com/content/www/us/en/develop/articles/properly-detecting-intel-software-guard-extensions-in-your-applications.html) in your applications. | |||
There was a problem hiding this comment.
this is also redirected once more, but to a general SGX page
There was a problem hiding this comment.
Apart from this site in the Intel docs (which also contains the dead/redirecting link), I am unable to find anything pointing to the original article that was once linked here.
I would opt to simply remove this sentence, since the important things should already be explained by the article linked to in the previous sentence.
Signed-off-by: Daniel Weiße <[email protected]>
thomasten
approved these changes
Nov 13, 2023
Signed-off-by: Daniel Weiße <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
README.mdblog.edgeless.systemstowww.edgeless.systems/blog