Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coordinator: threshold manifest update support #785

Merged
merged 2 commits into from
Jan 14, 2025
Merged

coordinator: threshold manifest update support #785

merged 2 commits into from
Jan 14, 2025

Conversation

daniel-weisse
Copy link
Member

Proposed changes

  • Add a new manifest option .Config.UpdateThreshold to control the number of acknowledgements required to perform a full manifest update
    • This allows to define n users with update permission, but only require m users to acknowledge an update before its applied. Where m <= n
    • Can not be higher than the amount of users allowed to update the full manifest
    • If not set (0), all users have to acknowledge the update

@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit 18b2571
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/67861469b04c360008cce802

@daniel-weisse daniel-weisse added the no changelog This PR should not be part of the changelog label Jan 7, 2025
@daniel-weisse daniel-weisse force-pushed the dw/threshold-updates branch 3 times, most recently from 322e3d9 to 455ea05 Compare January 9, 2025 12:55
thomasten
thomasten requested changes Jan 10, 2025
View reviewed changes
coordinator/manifest/manifest.go Outdated Show resolved Hide resolved
coordinator/manifest/manifest.go Outdated Show resolved Hide resolved
coordinator/manifest/manifest_test.go Outdated Show resolved Hide resolved
coordinator/manifest/manifest.go Show resolved Hide resolved
@daniel-weisse daniel-weisse merged commit c0ea5c1 into master Jan 14, 2025
11 checks passed
@daniel-weisse daniel-weisse deleted the dw/threshold-updates branch January 14, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasten thomasten thomasten approved these changes

Assignees
No one assigned
Labels
no changelog This PR should not be part of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-weisse @thomasten