coordinator: remove obsolete GetRecoveryData #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs canceled.
|
daniel-weisse
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In UpdateManifest, the recovery data is read from the recovery object and later set on the store. This is not required. It seems to be a leftover from when the func directly called sealState on the store, which expected the recovery data as an argument (649b476#diff-c9d54b7fdb3156de2d7b059657402c439b0065ae9bdd6d0b294edc4a6d6b2f40L293).
Furthermore, this behavior can be destructive in cases where recovery and store are not in sync. This shouldn't happen, but may be caused in edge cases, for example, if you start with multiparty recovery and later accidentally rerun with singleparty recovery. (But fixing this is just best effort. We don't support switching enterprise features after deployment.)
Proposed changes