Prepare for Constellation's s3proxy. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These may target minio specific implementation details that the upstream S3 API may or may not have. Includes healthcheck, mc, minio-go, minio-java, minio-js, minio-py.
Some use technologies we don't want to maintain for now (s3cmd dotnet, php). Others test functionality s3proxy does not support (s3select).
BypassGovernanceRetention is not a valid flag if the target bucket hasn't set it. Missing error checks. Error msg wrapping.
Correctly set region when creating bucket. Use etag from previous put operations instead of hardcoded value in cases the etag may be different from the hardcoded value. Disable unsupported testcases. Autoformatting.
Use more layers to allow for partial rebuilds. Consistently sort source code files into build and run dirs. Remove extra scripts and files that scatter build instructions. Remove post-install step where files are removed from final image, use layering instead. Add AWS_CA_BUNDLE var so AWS SDK/CLI picks up on added CA certs.
derpsteb
force-pushed
the
constellation
branch
2 times, most recently
from
19400f3 to
fd9bf98
Compare
derpsteb
force-pushed
the
constellation
branch
from
fd9bf98 to
1df18e1
Compare
4 tasks
derpsteb
force-pushed
the
constellation
branch
from
bac4790 to
ba17210
Compare
|
please add our copyright line to all files that you modified and that have a copyright/license header |
derpsteb
force-pushed
the
constellation
branch
from
e2ff905 to
beac49d
Compare
thomasten
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes we make to upstream mint to make it applicable for testing Constellation's s3proxy.
See edgelesssys/constellation#2524 and the commit history for a description of the changes.