Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation indicator for URLs when using JSON format. #1

Closed
wants to merge 1 commit into from
+14 −3
Closed

Add deprecation indicator for URLs when using JSON format. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions django_extensions/management/commands/show_urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,11 @@ def handle(self, *args, **options):
raise CommandError("Error occurred while trying to load %s: %s" % (getattr(settings, urlconf), str(e)))

view_functions = self.extract_views_from_urlpatterns(urlconf.urlpatterns)
for (func, regex, url_name) in view_functions:
for (func, regex, url_name, *deprecated) in view_functions:
if len(deprecated) > 0:
deprecated = deprecated[0]
else:
deprecated = False
if hasattr(func, '__globals__'):
func_globals = func.__globals__
elif hasattr(func, 'func_globals'):
Expand All @@ -148,7 +152,7 @@ def handle(self, *args, **options):
decorator = ', '.join(decorators)

if format_style == 'json':
views.append({"url": url, "module": module, "name": url_name, "decorators": decorator})
views.append({"url": url, "module": module, "name": url_name, "decorators": decorator, "deprecated": deprecated})
else:
views.append(fmtr.format(
module='{0}.{1}'.format(style.MODULE(func.__module__), style.MODULE_NAME(func_name)),
Expand Down Expand Up @@ -203,6 +207,8 @@ def extract_views_from_urlpatterns(self, urlpatterns, base='', namespace=None):
"""
views = []
for p in urlpatterns:
deprecated = False

if isinstance(p, (URLPattern, RegexURLPattern)):
try:
if not p.name:
Expand All @@ -211,8 +217,13 @@ def extract_views_from_urlpatterns(self, urlpatterns, base='', namespace=None):
name = '{0}:{1}'.format(namespace, p.name)
else:
name = p.name
if hasattr(p, "deprecated"):
deprecated = p.deprecated

pattern = describe_pattern(p)
views.append((p.callback, base + pattern, name))
views.append(
(p.callback, base + pattern, name, deprecated)
)
except ViewDoesNotExist:
continue
elif isinstance(p, (URLResolver, RegexURLResolver)):
Expand Down