Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Actions #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatrikStenmark
Copy link
Contributor

This PR adds support for some things related to GitHub Actions. I just implement what I need personally here, but if this is interesting I can do the rest of the Actions related thins as well.

However, I'm not sure how to write tests for this, since I need a repo with GitHub Actions set up with artifacts saving, using secrets etc. I see some tests are using https://github.com/soudqwiggle/elixir-conspiracy, which seems to be used for testing. Should I make a PR there first to set up actions in a way that makes it possible to test?

@PatrikStenmark PatrikStenmark changed the title Add some Actions related functions Support GitHub Actions May 28, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 91.411% when pulling 02c7f23 on spatrik:github-actions into 19a0907 on edgurgel:master.

@edgurgel
Copy link
Owner

edgurgel commented Jun 2, 2020

Thanks for the PR!

I think you can do it with any repo that you can control. Once the response is stored you can even delete the repo if you want 👍

The auth token is always removed so it should be pretty safe

[pattern: "token [^\"]+", placeholder: "token yourtokencomeshere"]

I can give it a try if this doesn't work for you

@PatrikStenmark
Copy link
Contributor Author

Aha! I didn't know about that filtering. I will give it a try later this week.

@mrcasals
Copy link

mrcasals commented Jun 2, 2020

Hi! I just found out about this PR, good job! While you're at it, could you add support for the /workflows list endpoint? 🙏 I know I'm just barging in here and asking for stuff, but since you'll have to setup a test repo...

https://developer.github.com/v3/actions/workflows/

Thanks a lot!

@PatrikStenmark
Copy link
Contributor Author

My intention is to implement all the actions stuff except self-hosted runners (Since I don't have any self-hosted runners), so you're in luck :)

@mrcasals
Copy link

mrcasals commented Jun 2, 2020

@sPatrik oh, thank you very much! 😍 I see that there are some convenience methods like Tentacat.get and Tentacat.post which will help meanwhile 😄

Thank you both for your work! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants