Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: update integration testing workflow and add pytest configuration #110

Merged
merged 14 commits into from
Oct 17, 2024

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Oct 14, 2024

Description

This PR includes some necessary changes to use the updated integration testing action https://github.com/eduNEXT/integration-test-in-tutor. The changes are described below:

  • Added pytest and pytest-django requirements to run the tests.
  • Updated the integration test workflow to use the updated action.
  • Modified the target in the Makefile to use pytest for running unit tests, ensuring consistency in how tests are executed across all plugins.
  • Added a target in the Makefile and a script to run the integration tests.
  • Moved integration tests for the backends and the info view to the integration folders.

For more information about the changes and the reasoning behind them, please refer to the documentation on writing integration tests for the plugins: https://internal.docs.edunext.co/en/latest/internal/Teams/Descontrol/Internal_processes/integration_tests_in_plugins/integration_tests_with_openedx_components.html

Note for Reviewers

This PR does not move the unit test files to unit/ folders. That effort will be part of a future PR when integration tests are added to the plugin.

How to Test

Ensure that both unit and integration tests pass without issues in the GitHub CI/CD pipeline.

@magajh magajh force-pushed the mjh/update-integration-tests-workflow branch from 68efd4e to 720db4b Compare October 14, 2024 20:45
@magajh magajh force-pushed the mjh/update-integration-tests-workflow branch from 52b39db to 5f28dbb Compare October 15, 2024 02:05
@magajh magajh changed the title Refactor: Update workflow, script, and tests to use latest integration tests action refactor: update integration testing workflow and add pytest configuration Oct 16, 2024
@magajh magajh changed the title refactor: update integration testing workflow and add pytest configuration Refactor: update integration testing workflow and add pytest configuration Oct 16, 2024
@magajh magajh marked this pull request as ready for review October 16, 2024 10:06
@magajh magajh requested a review from a team as a code owner October 16, 2024 10:06
requirements/django.txt Outdated Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
@magajh magajh force-pushed the mjh/update-integration-tests-workflow branch from d6bf641 to a1ac0f3 Compare October 16, 2024 19:03
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@luisfelipec95 luisfelipec95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@magajh
Copy link
Contributor Author

magajh commented Oct 17, 2024

@BryanttV @luisfelipec95: updated the django txt file passed to the upgrade target

@magajh magajh merged commit 59e5ccb into master Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants