fix: allow using boolean as values in tenant configs when getting settings by organization #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bra-i-am
requested review from
MaferMazu,
dcoa and
luisfelipec95
and removed request for
JuanDavidBuitrago
MaferMazu
approved these changes
Feb 27, 2024
dcoa
approved these changes
Feb 28, 2024
bra-i-am
force-pushed
the
bc/fix-tenant-values-handler
branch
from
ed8f10a to
b4bb9d3
Compare
bra-i-am
changed the title
bra-i-am
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is created for a necessity arisen in the PR #808 from edunext-platform and allows using boolean types as values because when some tenant properties have a value
FalseorTrue, this is used to run two conditionals. e.g. if a tenant settingENABLE_COURSE_AUTHORING_MFEhas a valueFalse, even though we want to send the valueFalse, the conditional is skipped and is returned a None instead ofFalseTesting instructions
At this moment the useful way to test this PR would be running the PR #808 from edunext-platform