-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: sumac release support AP-1580
#230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @BryanttV ✨
You updated the dependencies and the documentation; this works in Tutor, and the backends work well.
I tested principally remotely at https://sumac.releases.edunext.link/, and everything worked as expected. We can have different tenants, and we have access to all of the API endpoints.
I left a brief comment in the Test case document for future review, but the rest looks good.
Is there a reason why the integration tests are failing or skipping? |
@BryanttV has this been tested in a remote env? |
@MaferMazu integration tests in nightly are failing for an unknown error, and as a consequence, the workflows for the other Tutor versions are getting cancelled. I'm going to open a PR with a fix to avoid this |
Although since Tutor 19 hasn't been released yet, seems like we have no way to know that the integration tests are passing for Sumac |
Yes @magajh , the changes were deployed and tested in our Sumac stage. |
Should we then wait for the new version of Tutor to merge this PR? |
@BryanttV I'd say is not necessary, we can close this PR and open a follow-up task to make sure the tests in Sumac are passing once tutor 19 is released |
b7a852f
to
b0be936
Compare
e052026
to
1852069
Compare
1852069
to
0f169a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ✨ It work as expected.
Description
This PR adds support for the Open edX Sumac release.
These were the changes made:
edx-platform
Sumac release.Testing instructions
eox-tenant
using this PR branch, you can use the steps in Tutor documentation.Related Issues