Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: sumac release support AP-1580 #230

Merged
merged 7 commits into from
Nov 22, 2024
Merged

perf: sumac release support AP-1580 #230

merged 7 commits into from
Nov 22, 2024

Conversation

BryanttV
Copy link
Contributor

Description

This PR adds support for the Open edX Sumac release.

These were the changes made:

  • Upgraded requirements based on the edx-platform Sumac release.
  • Updated the Integration Tests to use the Sumac release with Tutor.

Testing instructions

  1. Create an environment with Sumac release, you can use Tutor or TVM.
  2. Install the Django plugin eox-tenant using this PR branch, you can use the steps in Tutor documentation.
  3. Run the test cases. In this file, you can find more information about the plugin configuration.

Related Issues

@BryanttV BryanttV marked this pull request as ready for review November 18, 2024 21:43
@BryanttV BryanttV requested a review from a team as a code owner November 18, 2024 21:43
MaferMazu
MaferMazu previously approved these changes Nov 20, 2024
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @BryanttV

You updated the dependencies and the documentation; this works in Tutor, and the backends work well.

I tested principally remotely at https://sumac.releases.edunext.link/, and everything worked as expected. We can have different tenants, and we have access to all of the API endpoints.

I left a brief comment in the Test case document for future review, but the rest looks good.

@MaferMazu
Copy link
Contributor

Is there a reason why the integration tests are failing or skipping?

@MaferMazu MaferMazu self-requested a review November 20, 2024 20:22
@magajh
Copy link
Contributor

magajh commented Nov 20, 2024

@BryanttV has this been tested in a remote env?

@magajh
Copy link
Contributor

magajh commented Nov 20, 2024

Is there a reason why the integration tests are failing or skipping?

@MaferMazu integration tests in nightly are failing for an unknown error, and as a consequence, the workflows for the other Tutor versions are getting cancelled. I'm going to open a PR with a fix to avoid this

@magajh
Copy link
Contributor

magajh commented Nov 20, 2024

Although since Tutor 19 hasn't been released yet, seems like we have no way to know that the integration tests are passing for Sumac

@BryanttV
Copy link
Contributor Author

has this been tested in a remote env?

Yes @magajh , the changes were deployed and tested in our Sumac stage.

@BryanttV
Copy link
Contributor Author

Although since Tutor 19 hasn't been released yet, seems like we have no way to know that the integration tests are passing for Sumac

Should we then wait for the new version of Tutor to merge this PR?

@magajh
Copy link
Contributor

magajh commented Nov 21, 2024

@BryanttV I'd say is not necessary, we can close this PR and open a follow-up task to make sure the tests in Sumac are passing once tutor 19 is released

@magajh
Copy link
Contributor

magajh commented Nov 21, 2024

@BryanttV can we rebase with this branch #232 to see if it works?

magajh
magajh previously approved these changes Nov 22, 2024
@BryanttV BryanttV requested review from magajh and MaferMazu and removed request for MaferMazu November 22, 2024 14:55
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✨ It work as expected.

@BryanttV BryanttV merged commit ee3cf99 into master Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants