Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed public path replacement #15

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Asespinel
Copy link

@Asespinel Asespinel commented Jan 31, 2025

This PR aims to fix the improper path replacement from the ORA MFE to work with CDN.

How to test

  1. Install this MFE using this branch in a sumac environment you can follow the installation guide .
  2. Make sure to have a course with an Open Response Assesment and a student user to submit a response.
  3. Open your ORA route as an instructor and you should see your dashboard loading correcly:

Screenshot from 2025-01-30 19-16-37

@magajh magajh requested a review from a team February 4, 2025 16:07
Copy link

@jignaciopm jignaciopm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asespinel I see it well, but could you explain in this PR the reason for the problem and how this solves it?

@Asespinel
Copy link
Author

@jignaciopm The problem was that the path was incorrectly being taken in the initialize get method, it was adding '/ora-grading/' at the beginning of the path and hence it wasn't rendering the blocks correctly of each submission

@Asespinel Asespinel merged commit 94aa60d into ednx-release/sumac.master Feb 4, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants