Fix Dart Sass deprecation warning - global built-in function str-leng… #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th and str-slice are deprecated, changed to string.length and string.slice.
|
Thanks @posttoast , but you will need to change in the src too |
|
Note I've just pushed a change to master to update the sass package and fix warnings in the tests. If you want to rebase |
…th and str-slice are deprecated, changed to string.length and string.slice - updated source.
|
Thanks, I updated the pull request :) |
|
Issue with the github node runner atm. npm/cli#7814 - but looks good will merge. |
|
Thanks for picking up @posttoast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Dart Sass deprecation warning - global built-in function str-length and str-slice are deprecated, changed to string.length and string.slice.