Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: be defensive about pulling both email and external_id from braze… #23

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

iloveagent57
Copy link
Member

… export.
Apparently the export-users endpoint will export records with no "email" in them? 🤷

@iloveagent57
Copy link
Member Author

tests and quality pass in devstack, codecov isn't happy, just gonna merge:

(venv) root@327357d564d1:/edx/src/braze-client# make quality
touch tests/__init__.py
pylint braze tests test_utils *.py
pycodestyle braze tests  *.py
isort --check-only --diff --recursive tests test_utils braze *.py
/edx/src/braze-client/venv/lib/python3.8/site-packages/isort/main.py:1233: UserWarning: W0501: The following deprecated CLI flags were used and ignored: --recursive!
  warn(
/edx/src/braze-client/venv/lib/python3.8/site-packages/isort/main.py:1237: UserWarning: W0500: Please see the 5.0.0 Upgrade guide: https://pycqa.github.io/isort/docs/upgrade_guides/5.0.0.html
  warn(
(venv) root@327357d564d1:/edx/src/braze-client# make test
find . -name '__pycache__' -exec rm -rf {} +
find . -name '*.pyc' -exec rm -f {} +
find . -name '*.pyo' -exec rm -f {} +
find . -name '*~' -exec rm -f {} +
coverage erase
rm -fr build/
rm -fr dist/
rm -fr *.egg-info
pytest
================================================================================== test session starts ===================================================================================
platform linux -- Python 3.8.10, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
rootdir: /edx/src/braze-client, configfile: tox.ini
plugins: cov-3.0.0
collected 39 items

tests/braze/test_client.py .......................................                                                                                                                 [100%]

---------- coverage: platform linux, python 3.8.10-final-0 -----------
Name                  Stmts   Miss  Cover   Missing
---------------------------------------------------
braze/__init__.py         1      0   100%
braze/client.py         182      3    98%   252, 352, 354
braze/constants.py       18      0   100%
braze/exceptions.py      11      0   100%
---------------------------------------------------
TOTAL                   212      3    99%
Coverage XML written to file coverage.xml


=================================================================================== 39 passed in 2.60s ===================================================================================

@iloveagent57 iloveagent57 merged commit 08698ab into main Jan 29, 2024
3 of 5 checks passed
@iloveagent57 iloveagent57 deleted the aed/defend-no-email branch January 29, 2024 15:00
iloveagent57 added a commit to openedx/license-manager that referenced this pull request Jan 29, 2024
edx/braze-client#23
Be defensive about presence of an `email` field when reading
response from the export-users endpoint.
iloveagent57 added a commit to openedx/license-manager that referenced this pull request Jan 29, 2024
edx/braze-client#23
Be defensive about presence of an `email` field when reading
response from the export-users endpoint.
iloveagent57 added a commit to openedx/license-manager that referenced this pull request Feb 1, 2024
edx/braze-client#23
Be defensive about presence of an `email` field when reading
response from the export-users endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants