Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enterprise subsidy to devstack #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add enterprise subsidy to devstack #84

wants to merge 1 commit into from

Conversation

mfarhan943
Copy link

@mfarhan943 mfarhan943 commented Nov 19, 2024 •
edited
Loading

Related Ticket:
#76

Related PR:
openedx/enterprise-subsidy#319

Tasks
Beta Give feedback

iamsobanjaved
iamsobanjaved reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions, rest looks good.

docker-compose.yml Outdated Show resolved Hide resolved
provision-enterprise-subsidy.sh Outdated Show resolved Hide resolved
provision-mysql80.sql Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mfarhan943 mfarhan943 force-pushed the farhan/add-enterprise-subsidy branch from 4835844 to 731be3f Compare November 26, 2024 10:36
@mfarhan943
Copy link
Author

Just a few suggestions, rest looks good.

I have applied the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfarhan943 @iamsobanjaved