Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enterprise-access to devstack #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamsobanjaved
Copy link
Member


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@iamsobanjaved iamsobanjaved force-pushed the iamsobanjaved/enterprise-access branch from 3769273 to 47c0f3a Compare December 2, 2024 11:34
Comment on lines +400 to +403
networks:
default:
aliases:
- edx.devstack.enterprise-access
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this... as it's already in the same docker-compose file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it is there to define its alias. Also present in other IDAs in this docker-compose.yml file.

Comment on lines +442 to +445
networks:
default:
aliases:
- edx.devstack.enterprise-access-worker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above...

echo -e "${GREEN}Creating super-user for ${name}...${NC}"
docker compose exec -T ${name} bash -e -c "echo 'from django.contrib.auth import get_user_model; User = get_user_model(); User.objects.create_superuser(\"edx\", \"[email protected]\", \"edx\") if not User.objects.filter(username=\"edx\").exists() else None' | python /edx/app/enterprise-access/manage.py shell" -- "$name"

./provision-ida-user.sh ${name} ${name} ${port}
Copy link
Member

@mumarkhan999 mumarkhan999 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to update it as in the upcoming line
we're accessing user using this line

User.objects.get(username=\"${name}_worker\")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already adding _worker postfix here:

docker compose exec -T lms bash -e -c 'source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker manage_user $1_worker [email protected] --staff --superuser' -- "$app_name"


docker-compose up -d $name

# Run migrations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# Restart enterprise.catalog app and worker containers
# docker-compose restart app
make dev.restart-devserver.enterprise-access
Copy link
Member

@mumarkhan999 mumarkhan999 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: blank line needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants