-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enterprise-access to devstack #87
base: master
Are you sure you want to change the base?
Conversation
3769273
to
47c0f3a
Compare
networks: | ||
default: | ||
aliases: | ||
- edx.devstack.enterprise-access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this... as it's already in the same docker-compose file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it is there to define its alias
. Also present in other IDAs in this docker-compose.yml file.
networks: | ||
default: | ||
aliases: | ||
- edx.devstack.enterprise-access-worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above...
echo -e "${GREEN}Creating super-user for ${name}...${NC}" | ||
docker compose exec -T ${name} bash -e -c "echo 'from django.contrib.auth import get_user_model; User = get_user_model(); User.objects.create_superuser(\"edx\", \"[email protected]\", \"edx\") if not User.objects.filter(username=\"edx\").exists() else None' | python /edx/app/enterprise-access/manage.py shell" -- "$name" | ||
|
||
./provision-ida-user.sh ${name} ${name} ${port} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to update it as in the upcoming line
we're accessing user using this line
User.objects.get(username=\"${name}_worker\")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already adding _worker
postfix here:
devstack/provision-ida-user.sh
Line 16 in 731be3f
docker compose exec -T lms bash -e -c 'source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker manage_user $1_worker [email protected] --staff --superuser' -- "$app_name" |
|
||
docker-compose up -d $name | ||
|
||
# Run migrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to use the following convention here
https://github.com/edx/devstack/blob/master/provision-notes.sh#L15
If yes, then we need to remove this line
https://github.com/edx/public-dockerfiles/blob/main/dockerfiles/enterprise-access.Dockerfile#L121
|
||
# Restart enterprise.catalog app and worker containers | ||
# docker-compose restart app | ||
make dev.restart-devserver.enterprise-access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: blank line needed
I've completed each of the following or determined they are not applicable: