feat!: Rename ConfigWatcher app and configure as plugin; reduce fields #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ConfigWatcher needs to be configured as a plugin to be loaded into edxapp, since we don't use INSTALLED_APPS for this dependency. - On the renaming: This is the name I actually meant to write in the first place. - Remove some fields that are less likely to be interesting and are likely to just result in clutter.
7 tasks
dianakhuang
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-tested in devstack. This time, I only had to add the
CONFIG_WATCHER_SLACK_WEBHOOK_URLsetting in order for the plugin to activate -- no need to add to INSTALLED_APPS.Merge checklist:
Check off if complete or not applicable: