feat: Log addition of config watchers and make receivers unique #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add log message for each model the ConfigWatcher is listening to, mostly so I can tell whether this app is even getting loaded. - Add dispatch_uid to receivers so that if `ready` (or `connect_receivers`) is called more than once, the receiver is only attached once. (This is not a response to an observed problem -- it's just a best practice according to Django docs.)
dianakhuang
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready(orconnect_receivers) is called more than once, the receiver is only attached once. (This is not a response to an observed problem -- it's just a best practice according to Django docs.)Merge checklist:
Check off if complete or not applicable: