feat: Add datadog-api-client to dev deps so script is easier to use #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It still makes sense for the script to explicitly call out this dependency in its --help message, but we can also install the dep automatically for people calling it from the context of a fully installed venv for this repo.
|
Yeah, didn't occur to me during review either. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still makes sense for the script to explicitly call out this dependency in its --help message, but we can also install the dep automatically for people calling it from the context of a fully installed venv for this repo.
Merge checklist:
Check off if complete or not applicable:
Version bumpedChangelog record addedDocumentation updated (not only docstrings)Fixup commits are squashed awayUnit tests added/updatedManual testing instructions providedNoted any: Concerns, dependencies, migration issues, deadlines, tickets