Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove temporary rollout span tag code_owner_plugin #873

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat!: remove temporary rollout span tag code_owner_plugin #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca70709
feat!: remove temporary rollout span tag code_owner_plugin
robrap Dec 12, 2024
ac6628d
fixup! add changelog entry
robrap Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Change Log

Unreleased
~~~~~~~~~~
Removed
-------
* Removed temporary rollout span tag ``code_owner_plugin`` used for the code owner monitoring move from edx-django-utils. Now that edx-django-utils monitoring has been disabled, this span tag serves no purpose.

[6.1.0] - 2024-12-10
~~~~~~~~~~~~~~~~~~~~
Expand Down
9 changes: 0 additions & 9 deletions edx_arch_experiments/datadog_monitoring/code_owner/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,6 @@ def set_code_owner_custom_span_tags(code_owner):
# to the code_owner span tag.
set_custom_attribute('code_owner_squad', code_owner)

# .. custom_attribute_name: code_owner_plugin
# .. custom_attribute_description: This is a temporary span tag to roll out the
# the switch from edx-django-utils to this plugin. If this span tag is True,
# the plugin has added the above custom span tags (possibly in addition to
# edx-django-utils). If the code_owner_theme span tag is also seen, then
# edx-django-utils is also adding these span tags. If not, only the plugin is
# creating these tags.
set_custom_attribute('code_owner_plugin', True)


def set_code_owner_span_tags_from_request(request):
"""
Expand Down
1 change: 0 additions & 1 deletion edx_arch_experiments/datadog_monitoring/tests/code_owner/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ def _assert_set_custom_attribute(
if code_owner:
call_list.append(call('code_owner', code_owner))
call_list.append(call('code_owner_squad', code_owner))
call_list.append(call('code_owner_plugin', True))
if module:
call_list.append(call('code_owner_module', module))
if has_path_error:
Expand Down
Loading