Skip to content

Commit

Permalink
Merge pull request #153 from edx/aadnan/migrate-reactifex
Browse files Browse the repository at this point in the history
feat: migrate translations to reactifex
  • Loading branch information
AliAdnanSohail authored Mar 18, 2022
2 parents a356234 + 5e5c3ff commit 189f33e
Show file tree
Hide file tree
Showing 4 changed files with 173 additions and 5 deletions.
7 changes: 4 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export TRANSIFEX_RESOURCE = frontend-component-footer-edx
transifex_resource = frontend-component-footer-edx
transifex_langs = "ar,fr,es_419,zh_CN"

Expand Down Expand Up @@ -42,11 +43,11 @@ push_translations:
# Pushing strings to Transifex...
tx push -s
# Fetching hashes from Transifex...
./node_modules/reactifex/bash_scripts/get_hashed_strings.sh $(tx_url1)
./node_modules/@edx/reactifex/bash_scripts/get_hashed_strings_v3.sh
# Writing out comments to file...
$(transifex_utils) $(transifex_temp) --comments
$(transifex_utils) $(transifex_temp) --comments --v3-scripts-path
# Pushing comments to Transifex...
./node_modules/reactifex/bash_scripts/put_comments.sh $(tx_url2)
./node_modules/@edx/reactifex/bash_scripts/put_comments_v3.sh

# Pulls translations from Transifex.
pull_translations:
Expand Down
166 changes: 166 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"@edx/frontend-build": "5.6.14",
"@edx/frontend-platform": "1.15.2",
"@edx/paragon": "14.16.10",
"@edx/reactifex": "^1.0.3",
"codecov": "3.8.3",
"enzyme": "3.11.0",
"enzyme-adapter-react-16": "1.15.6",
Expand Down
4 changes: 2 additions & 2 deletions src/components/LanguageSelector.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const LanguageSelector = ({
<FormattedMessage
id="footer.languageForm.select.label"
defaultMessage="Choose Language"
description="The label for the laguage select part of the language selection form."
description="The label for the language select part of the language selection form."
/>
</div>
</label>
Expand All @@ -42,7 +42,7 @@ const LanguageSelector = ({
<FormattedMessage
id="footer.languageForm.submit.label"
defaultMessage="Apply"
description="The label for button to submit the language selection form."
description="Label for button to submit the language selection form."
/>
</button>
</form>
Expand Down

0 comments on commit 189f33e

Please sign in to comment.