fix: change Paragon to a peerDependency #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "js-cookie": "^3.0.1", | ||
| "lodash": "^4.17.21" | ||
| }, | ||
| "peerDependencies": { | ||
| "@edx/frontend-platform": "^7.0.0 || ^8.0.0", | ||
| "@openedx/paragon": ">= 21.11.3 < 23.0.0", |
There was a problem hiding this comment.
[sanity check] is there anything in the major upgrade from v21 to v22 that could break frontend-component-footer-edx? That is, will supporting an older v21 version be compatible given it was previously using v22? If not, then I agree, expanding the support back to v21 is reasonable :)
There was a problem hiding this comment.
Ahh good call out. I was just replicating what was done in the Open edX version. This at least gives some reassurance. But looking at the breaking changes for v22, I don't see anything in there that would cause footer to break. The components called out in the release notes aren't used by frontend-component-footer-edx.
adamstankiewicz
approved these changes
Sep 5, 2024
BilalQamar95
approved these changes
Sep 6, 2024
MaxFrank13
force-pushed
the
mfrank/remove-dependency
branch
from
88f9f15 to
bf9aa64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When carrying over some changes from the OpenedX version of the footer, we changed Paragon from a peerDependency to a regular dependency (source). The Open edX footer has since fixed this and correctly has Paragon set to a peerDependency (source).
Paragon should be a peerDependency here so that users don't end up having to download multiple versions of Paragon and we don't introduce any style regressions.