Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove Transifex calls for OEP-58 for for header #620

Closed
wants to merge 2 commits into from
Closed

feat: remove Transifex calls for OEP-58 for for header #620

wants to merge 2 commits into from

Conversation

sundasnoreen12
Copy link
Collaborator

INF-1722
Similar to openedx/frontend-app-account#887

Description

  1. Removes all direct use of tx pull and tx push commands from the micro-frontend in favor of the atlas pull command.
  2. Remove source and language translations from the repositories, hence no .json files will be committed into the repos.
  3. src/i18n/index.js should export and empty array so the make pull_translations override it with the dynamic list of languages.
  4. Remove the experimental OPENEDX_ATLAS_PULL flag to make atlas pull the default.
  5. Remove all Transifex related Makefile targets and other files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais-ansari awais-ansari awais-ansari approved these changes

@muhammadadeeltajamul muhammadadeeltajamul muhammadadeeltajamul approved these changes

@ayesha-waris ayesha-waris Awaiting requested review from ayesha-waris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundasnoreen12 @muhammadadeeltajamul @awais-ansari