Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependency specifications #63

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bradenmacdonald
Copy link
Member

@bradenmacdonald bradenmacdonald commented Nov 6, 2024

Upgrade PRs like openedx/frontend-app-learning#934 are currently blocked because this plugin is overly specifying its dependencies. There were also a number of other problems which I've fixed - see inline comments.

npm warn Could not resolve dependency:
npm warn peer redux@"4.1.2" from @edx/[email protected]
npm warn node_modules/@edx/frontend-lib-learning-assistant
npm warn   @edx/frontend-lib-learning-assistant@"^2.2.4" from the root project

@bradenmacdonald bradenmacdonald force-pushed the braden/fix-dependencies branch from 2f65e4d to 1f3d6cd Compare November 6, 2024 21:47
"@fortawesome/free-brands-svg-icons": "5.15.4",
"@fortawesome/free-regular-svg-icons": "5.15.4",
"@fortawesome/free-solid-svg-icons": "5.15.4",
"@fortawesome/react-fontawesome": "0.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These font awesome dependencies aren't even used.

"@optimizely/react-sdk": "^2.9.2",
"core-js": "^3.36.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core-js is not needed in 2024.

"@edx/reactifex": "^2.1.1",
"@openedx/frontend-build": "14.0.3",
"@openedx/paragon": "^22.2.0",
"@reduxjs/toolkit": "1.8.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These deps are all specified by the learning MFE and are already in peerDependencies so they don't also need to be in devDependencies.

"react-router": "6.15.0",
"react-router-dom": "6.15.0",
"redux": "4.1.2",
"regenerator-runtime": "0.13.11",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regenerator-runtime is not needed in 2024.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (ce3677d) to head (5aed7e5).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   81.36%   82.14%   +0.77%     
==========================================
  Files          13       18       +5     
  Lines         220      280      +60     
  Branches       30       52      +22     
==========================================
+ Hits          179      230      +51     
- Misses         39       48       +9     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradenmacdonald
Copy link
Member Author

@rijuma @alangsto Could you please take a look at this?

Copy link
Member

@alangsto alangsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

@bradenmacdonald
Copy link
Member Author

Thanks @alangsto! I will need someone on your side to merge this whenever ready.

@alangsto
Copy link
Member

@bradenmacdonald I can go ahead and merge this now, but because the commit type is chore, merging this PR will not trigger a semantic release. If that's fine, let me know and I will merge! Otherwise, feel free to update the commit type to something that will trigger the release, and I can merge after that.

@bradenmacdonald
Copy link
Member Author

@alangsto Good point; changed to fix :)

@alangsto alangsto merged commit 43c87e1 into edx:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants