Make "Actual exit status" always black when return code is not checked #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ | |||
| {'actual-return-code-correct': ag_test_command_result !== null | |||
| && ag_test_command_result.return_code_correct, | |||
| 'actual-return-code-incorrect': ag_test_command_result !== null | |||
| && !ag_test_command_result.return_code_correct}]" | |||
| && ag_test_command_result.return_code_correct === false}]" | |||
There was a problem hiding this comment.
Can you add a short comment reminding that return_code_correct can be null? Just since this kind of explicit bool check doesn't show up anywhere else in the codebase.
There was a problem hiding this comment.
@james-perretta Added in latest commit
james-perretta
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses eecs-autograder/autograder.io#30.
When applying classes to the Actual exit status code, it changes the check for
ag_test_command_result.return_code_correctfrom!ag_test_command_result.return_code_correcttoag_test_command_result.return_code_correct === falseso that the incorrect return code class is no longer applied ifag_test_command_result.return_code_correctisnull.I have included a new test that verifies this functionality. Without the change above, the test fails.
Screenshots
Before
After
@james-perretta Please review this at your earliest convenience. Thank you!