Check and apply max deduction for handgrading annotations #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-perretta
requested changes
Apr 26, 2024
...st_components/test_project_view/test_submission_detail/test_ag_test_command_result_detail.ts
Outdated
Show resolved
Hide resolved
Replaced forceUpdate with expect(await wait_until(wrapper, w => !w.vm.saving)).toBe(true); previously written test case Handgraders allowed to leave custom comments
src/components/project_view/submission_detail/ag_test_command_result_detail.vue
Outdated
Show resolved
Hide resolved
james-perretta
approved these changes
Apr 27, 2024
|
Thanks again for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #502. When an annotation is applied or deleted in the Handgrading interface, we compute the effective change to the score based on its max deduction and total number of applications so far.
Tests are included for both applying and deleting annotations across the max deduction boundary. Additional tests are included for cases where the max deduction of an annotation is not a multiple of its unit deduction, such as ("-3/-7 max"). This PR's implementation changes makes those tests pass.
This PR is a copy of #512, which had to be reopened to circumvent GitHub's erroneous stale review checks.