Add docker stack for e2e tests, remove cypress #524
Conversation
MattyMay
force-pushed
the
setup-e2e
branch
16 times, most recently
from
a028f4d to
1a8caeb
Compare
MattyMay
force-pushed
the
setup-e2e
branch
2 times, most recently
from
e38cea2 to
1a8caeb
Compare
| .first() | ||
| .should("contain.text", "closing time"); | ||
|
|
||
| // make sure error goes away after valid request |
There was a problem hiding this comment.
This suggests that there would be a check such as .get_api_errors().should("have.length", 0), but I don't see that below. Should there be?
There was a problem hiding this comment.
Ah this isn't very clear. save_and_reload() verifies that there are no API errors after saving and after reloading. It's mentioned in the jsdoc but maybe I should rename the action? Or get rid of the action and just call save().get_api_errors() ... refresh().get_api_errors() ... ?
| .should("contain.text", "integer") | ||
| .get_by_testid(ElementId.save) | ||
| .should("be.disabled") | ||
| .click({ force: true }) |
There was a problem hiding this comment.
Is this basically saying "act as if the user clicked the mouse on the disabled button", with the expectation that nothing happens (i.e., the form is not submitted)?
There was a problem hiding this comment.
Yes. Maybe a silly thing to test 🤷
Remove cypress
james-perretta
changed the title
Add e2e testing configuration and e2e tests for the project settings pageAdd docker stack for e2e tests & remove cypress