added enter key functionality for submit #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you please add a couple test cases that cover the added code? |
Hi, I added two test cases in the new commit, please check! |
| @@ -66,10 +66,11 @@ | |||
| "@vitejs/plugin-vue2": "^1.1.2", | |||
| "@vue/cli-plugin-typescript": "^4.5.11", | |||
| "@vue/cli-service": "^4.5.11", | |||
| "@vue/test-utils": "^1.3.0", | |||
| "@vue/test-utils": "^1.3.6", | |||
There was a problem hiding this comment.
Were there issues with running the tests? We recently switched from jest to vitest, so these dependency updates shouldn't be needed.
| @@ -11,7 +11,7 @@ import ExpectedStudentFilesList from '@/components/project_view/expected_student | |||
| import GroupMembers from '@/components/project_view/group_members.vue'; | |||
| import Submit from '@/components/project_view/submit.vue'; | |||
| import { format_datetime } from '@/utils'; | |||
|
|
|||
| import Vue from 'vue'; | |||
There was a problem hiding this comment.
Remove (unused import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is John, the working partner of @cycai0312 for our software engineering homework assignment. I hereby enhance your project by adding enter key submission functionality related to open issue #47. (reference: eecs-autograder/autograder.io#47)
I am the same person as @jpswag from pull request #530, and I redid this pull request because of some file formatting and authentication issues for my username @jpswag.