Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile should not mess up with the $PATH #17

Open
proppy opened this issue Jan 12, 2023 · 2 comments
Open

Makefile should not mess up with the $PATH #17

proppy opened this issue Jan 12, 2023 · 2 comments

Comments

@proppy
Copy link
Contributor

proppy commented Jan 12, 2023

This currently break integration with currently activated venv or conda environment:

$ python3 -m venv env
$ source env/bin/activate
$ python -m pip install mpremote
$ cd firmware_vex/nucleo/
$ make run
mpremote connect /dev/cu.usbmodem34203 exec "import machine; machine.reset()"
/bin/sh: 1: mpremote: not found

If you remove the line at https://github.com/efabless/caravel_board/blob/main/firmware_vex/nucleo/Makefile#L2 it works as expected (mpremote get resolve from the currently activated environment).

@ayushman22git
Copy link

ayushman22git commented Jan 13, 2023

@proppy
Copy link
Contributor Author

proppy commented Jan 18, 2023

proppy@ce91da7 was enough for me for the Makefile to pick up things in my local venv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants