Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use .NET 8 RTM #5

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update to use .NET 8 RTM #5

merged 1 commit into from
Jan 18, 2024

Conversation

ErikEJ
Copy link
Member

@ErikEJ ErikEJ commented Dec 30, 2023

Update test dependencies

Use 8.0 System.Configuration.ConfigurationManager that has less dependencies than the the 6.0 version (including System.Common.Drawing!)

Update test dependencies

Use 8.0 System.Configuration.ConfigurationManager that has less dependencies than the the 6.0 version (including System.Common.Drawing!)
@ErikEJ
Copy link
Member Author

ErikEJ commented Dec 30, 2023

@roji @bricelam FYI

@ErikEJ
Copy link
Member Author

ErikEJ commented Jan 4, 2024

@roji Thoughts?

@roji
Copy link
Member

roji commented Jan 4, 2024

@ErikEJ this definitely looks OK to me - I can merge it, but I don't think I have permissions to publish the nuget...

@bricelam are you interested in continuing to maintain this etc.?

@ErikEJ
Copy link
Member Author

ErikEJ commented Jan 4, 2024

If not I am happy to help and support

@roji
Copy link
Member

roji commented Jan 4, 2024

If @bricelam is good with it, I think we'd be happy for you to take over this!

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a thought - we could align the versions of this library to the version of EF it requires, like for EFCore.NamingConventions/CheckConstraints (rather than have a table that tells you which version goes with which).

@ErikEJ ErikEJ merged commit 0f0234e into efcore:main Jan 18, 2024
1 check passed
@bricelam
Copy link
Member

Wait, what's the value here? If you have EF8 installed, then add the 2.0 version of this package won't the end result be the same?

With this package and my pluralizer, I've avoided publishing any new versions unless they actually get broken by EF.

@bricelam
Copy link
Member

P.S. Sorry for my limited availability lately. Life's been really busy. It's not an intentional absence, and hopefully it's just a point-in-time thing.

@bricelam
Copy link
Member

@bricelam are you interested in continuing to maintain this etc.?

Yes. Unless the EF Team thinks I'm doing a bad job or disagrees with my decisions for it--then I'm happy to relinquish it to them.

@ErikEJ
Copy link
Member Author

ErikEJ commented Jan 19, 2024

@bricelam

won't the end result be the same?

Not exactly:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="EntityFrameworkCore.ConfigurationManager" Version="2.0.0" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.1" />
  </ItemGroup>

</Project>

Publish:

image

Then add:

<PackageReference Include="System.Configuration.ConfigurationManager" Version="8.0.0" />

Publish:

image

@bricelam
Copy link
Member

Alright. Yeah, I'm fine shipping this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants