-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use .NET 8 RTM #5
Conversation
Update test dependencies Use 8.0 System.Configuration.ConfigurationManager that has less dependencies than the the 6.0 version (including System.Common.Drawing!)
@roji Thoughts? |
If not I am happy to help and support |
If @bricelam is good with it, I think we'd be happy for you to take over this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a thought - we could align the versions of this library to the version of EF it requires, like for EFCore.NamingConventions/CheckConstraints (rather than have a table that tells you which version goes with which).
Wait, what's the value here? If you have EF8 installed, then add the 2.0 version of this package won't the end result be the same? With this package and my pluralizer, I've avoided publishing any new versions unless they actually get broken by EF. |
P.S. Sorry for my limited availability lately. Life's been really busy. It's not an intentional absence, and hopefully it's just a point-in-time thing. |
Yes. Unless the EF Team thinks I'm doing a bad job or disagrees with my decisions for it--then I'm happy to relinquish it to them. |
Not exactly: <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="EntityFrameworkCore.ConfigurationManager" Version="2.0.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.1" />
</ItemGroup>
</Project> Publish: Then add:
Publish: |
Alright. Yeah, I'm fine shipping this. |
Update test dependencies
Use 8.0 System.Configuration.ConfigurationManager that has less dependencies than the the 6.0 version (including System.Common.Drawing!)