if we're knocked out, don't flail our legs and arms when airborn

[VinniTR]

Description

Let's keep this here in the meantime.

Type of Changes

	Type
✓	🐛 Bug fix

[EraOSBeta]

This can pass into scenev1 if flailing doesn't really affect anything in the physics simulation

[efroemling]

This would slightly affect physics sims in some cases: older clients would be simulating with flailing limbs while the servers they are connected to would not, so there'd be some popping and resyncing until everyone got the update. But I don't think that would be too problematic.

Rather my main question with this would be: does it make things funnier or improve gameplay? The knockout mechanism is kinda meant to just mean that a character is too stunned to stand; I don't think it breaks any logic if they still wave their arms when flying through the air. Right now one can tell at a glance if a flying character is alive or dead by whether they are flailing, but this would complicate that. And I worry that a large percentage of events that launch a character through the air would also knock them out, meaning that we could essentially just be removing flailing, which is no fun.

So anyway I'm probably against this for those reasons, but I do want to be receptive to other opinions if you feel it is an improvement.

[VinniTR]

@efroemling i think it's funny because the character would be like a rag doll every time he goes flying, whether due to a punch or an explosion, the death animation could be modified a little to avoid confusion with living and dead people, if that's what it is what you mean...

[EraOSBeta]

@VinniTR can you show us a comparison video between the old behavior and the new one so we could compare the funni value?

[VinniTR]

@VinniTR can you show us a comparison video between the old behavior and the new one so we could compare the funni value?

i dont know how :cc

[vishal332008]

@efroemling @VinniTR @EraOSBeta
Normal (without the code):
https://github.com/user-attachments/assets/53f08fc0-ad99-444d-8255-37c4a7775a4d

New (with the code):
https://github.com/user-attachments/assets/e277f614-b44d-456d-9d4a-a221b6f4b140

Now decide.

[EraOSBeta]

Seems to add a bit of funni, but I think it would be nice to have both this and the old behavior available in the game at the same time with the new behavior being a toggle in the advanced menu for a few versions; this way we could merge this for now while the people decide which one is better.

I think in general we need an "Experiments" section in the advanced settings to add all sorts of QoL changes there for stuff like this, when we aren't really sure if the change is better or worse.