Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

refactor(getQueryStringParam): Escape all regex special characters in… #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boyandim
Copy link

… the name parameter.

Currently the method is escaping only for the "[" and "]". The main idea is to escape all special characters that can be used in the regex expression itself.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #24 into master will not affect coverage as of 9c890e3

@@            master     #24   diff @@
======================================
  Files            7       7       
  Stmts           26      26       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             26      26       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 9c890e3

Powered by Codecov. Updated on successful CI builds.

@kentcdodds
Copy link
Member

Hi! Thanks for the contribution! A few things:

  1. The commit message subject is too long. Could you shorten that a bit?
  2. Could you add a test or two for your improved functionality?

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants