fix: loadFile ignore ts extend on readFileSync #294
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Caller
participant LoadFile as loadFile
participant ExtCheck as Extension Check
participant FileRead as File Read Logic
Caller->>LoadFile: Call loadFile(filepath)
LoadFile->>ExtCheck: Check if file extension is in allowed list
ExtCheck-->>LoadFile: Return result
alt File has .ts extension
LoadFile->>Caller: Process file without buffer read
else File is not .ts
LoadFile->>FileRead: Read file as buffer
FileRead-->>LoadFile: Return file data
LoadFile->>Caller: Return file data
end
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
src/utils/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eggache". (The package "eslint-plugin-eggache" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eggache" was referenced from the config file in ".eslintrc » eslint-config-egg/typescript » ./index.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 11 11
Lines 3548 3548
Branches 631 631
=======================================
Hits 3458 3458
Misses 90 90 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/utils/index.ts (1)
81-81: Consider adding a comment explaining the TypeScript handling.For better maintainability, consider adding a comment explaining why TypeScript files need special handling:
// if not js module, just return content buffer const extname = path.extname(filepath); + // Ensure TypeScript files are imported properly instead of being read as raw buffers if (extname && !extensionNames.includes(extname) && extname !== '.ts') {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/utils/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: Node.js / Test (windows-latest, 23)
- GitHub Check: Node.js / Test (windows-latest, 22)
- GitHub Check: Node.js / Test (windows-latest, 20)
- GitHub Check: Node.js / Test (windows-latest, 18.19.0)
- GitHub Check: Node.js / Test (windows-latest, 18)
- GitHub Check: Node.js / Test (ubuntu-latest, 23)
- GitHub Check: Node.js / Test (ubuntu-latest, 22)
- GitHub Check: Node.js / Test (ubuntu-latest, 20)
- GitHub Check: Node.js / Test (ubuntu-latest, 18.19.0)
- GitHub Check: Node.js / Test (macos-latest, 18.19.0)
- GitHub Check: Node.js / Test (ubuntu-latest, 18)
- GitHub Check: Node.js / Test (macos-latest, 22)
- GitHub Check: Node.js / Test (macos-latest, 20)
- GitHub Check: Node.js / Test (macos-latest, 18)
🔇 Additional comments (1)
src/utils/index.ts (1)
81-81: LGTM! Fix ensures TypeScript files are properly imported.The change correctly ensures that TypeScript files are not read as raw buffers via
readFileSync, but instead are properly imported usingimportModule. This fixes the handling of TypeScript files that were previously being treated as non-JS modules.
[skip ci] ## [6.3.2](v6.3.1...v6.3.2) (2025-02-16) ### Bug Fixes * loadFile ignore ts extend on readFileSync ([#294](#294)) ([1cf0a53](1cf0a53))
eggjs/tegg#283
Summary by CodeRabbit