Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated db-migration script and docker file #685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated db-migration script and docker file #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core-services/pdf-service/migration/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM egovio/flyway:4.1.2
FROM egovio/flyway:10.7.1

COPY ./ddl /flyway/sql

Expand All @@ -8,4 +8,4 @@ COPY migrate.sh /usr/bin/migrate.sh

RUN chmod +x /usr/bin/migrate.sh

CMD ["/usr/bin/migrate.sh"]
ENTRYPOINT ["/usr/bin/migrate.sh"]
2 changes: 1 addition & 1 deletion core-services/pdf-service/migration/migrate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/sh

flyway -url=$DB_URL -table=$SCHEMA_TABLE -user=$FLYWAY_USER -password=$FLYWAY_PASSWORD -locations=$FLYWAY_LOCATIONS -baselineOnMigrate=true -outOfOrder=true -ignoreMissingMigrations=true migrate
flyway -url=$DB_URL -table=$SCHEMA_TABLE -user=$FLYWAY_USER -password=$FLYWAY_PASSWORD -locations=$FLYWAY_LOCATIONS -baselineOnMigrate=true -outOfOrder=true migrate
4 changes: 2 additions & 2 deletions core-services/pdf-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"author": "Jason Miller <[email protected]>",
"license": "MIT",
"dependencies": {
"axios": "^0.18.0",
"axios": "0.18.0",
"body-parser": "^1.13.3",
"compression": "^1.5.2",
"cors": "^2.7.1",
Expand Down Expand Up @@ -68,7 +68,7 @@
"eslint": "^3.1.1",
"mustache": "^3.0.1",
"nodemon": "^1.19.4",
"pdfmake": "^0.2.2"
"pdfmake": "0.2.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Lock pdfmake Version in DevDependencies

The pdfmake dependency in the devDependencies has been updated to "pdfmake": "0.2.2" (fixed version) as intended. However, note that the dependencies section lists "pdfmake": "0.2.4", which is inconsistent with the intended update.

Would you like to align the dependency versions by updating the dependencies section to "0.2.2"? For example, applying the following diff could resolve the discrepancy:

-    "pdfmake": "0.2.4",
+    "pdfmake": "0.2.2",

Committable suggestion skipped: line range outside the PR's diff.

},
"bugs": {
"url": "https://github.com/egovernments/core-services/issues"
Expand Down