Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CorrectionWithGradient.eval_dict #35

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Remove CorrectionWithGradient.eval_dict #35

merged 1 commit into from
Oct 29, 2023

Conversation

eguiraud
Copy link
Owner

It does not work well with vectorized calls:
we would like to vectorize over the values of
the dictionary, but e.g. np.vectorized does not do
that out of the box.

We'll have to revise later in what form we can
reintroduce (something like) eval_dict, if any,
e.g. using kwargs instead of an input dict.

It does not work well with vectorized calls:
we would like to vectorize over the values of
the dictionary, but e.g. np.vectorized does not do
that out of the box.

We'll have to revise later in what form we can
reintroduce (something like) eval_dict, if any,
e.g. using kwargs instead of an input dict.
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ef9370) 100.00% compared to head (542314a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           80        74    -6     
  Branches        11         9    -2     
=========================================
- Hits            80        74    -6     
Files Coverage Δ
src/correctionlib_gradients/_base.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguiraud
Copy link
Owner Author

eguiraud commented Oct 29, 2023

Merge activity

@eguiraud eguiraud merged commit e099f29 into main Oct 29, 2023
9 checks passed
@eguiraud eguiraud deleted the rm-eval-dict branch October 29, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant