Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: return an array of the correct size from scale corrections, add test #37

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

eguiraud
Copy link
Owner

@eguiraud eguiraud commented Oct 29, 2023

No description provided.

@eguiraud
Copy link
Owner Author

eguiraud commented Oct 29, 2023

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0aac516) 100.00% compared to head (8697c8c) 94.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #37      +/-   ##
===========================================
- Coverage   100.00%   94.38%   -5.62%     
===========================================
  Files            3        3              
  Lines           74       89      +15     
  Branches         9       16       +7     
===========================================
+ Hits            74       84      +10     
- Misses           0        3       +3     
- Partials         0        2       +2     
Files Coverage Δ
src/correctionlib_gradients/_base.py 93.90% <75.00%> (-6.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguiraud eguiraud changed the title Test running cg.evaluate without jax involved Fix: return an array of the correct size from scale corrections, add test Oct 29, 2023
@eguiraud eguiraud changed the base branch from main to always-run-ci October 29, 2023 23:19
@eguiraud
Copy link
Owner Author

eguiraud commented Oct 29, 2023

Merge activity

  • Oct 29, 7:26 PM: @eguiraud started a stack merge that includes this pull request via Graphite.
  • Oct 29, 7:27 PM: Graphite rebased this pull request as part of a merge.
  • Oct 29, 7:33 PM: Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.
  • Oct 29, 7:43 PM: @eguiraud started a stack merge that includes this pull request via Graphite.
  • Oct 29, 7:43 PM: @eguiraud merged this pull request with Graphite.

Base automatically changed from always-run-ci to main October 29, 2023 23:27
@eguiraud eguiraud merged commit fa225b2 into main Oct 29, 2023
@eguiraud eguiraud deleted the test-no-jax branch October 29, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant