Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-compute spline once when bin contents are constant #41

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

eguiraud
Copy link
Owner

@eguiraud eguiraud commented Nov 3, 2023

Fixes #17.

@eguiraud
Copy link
Owner Author

eguiraud commented Nov 3, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec318a7) 100.00% compared to head (beb0575) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          333       345   +12     
  Branches        96        98    +2     
=========================================
+ Hits           333       345   +12     
Files Coverage Δ
src/correctionlib_gradients/_base.py 100.00% <100.00%> (ø)
.../correctionlib_gradients/_differentiable_spline.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguiraud eguiraud merged commit 73dd9ee into main Nov 4, 2023
9 checks passed
@eguiraud eguiraud deleted the precompute-spline branch November 4, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binning optimization: if bin contents are fixed, only produce the spline once and cache it
1 participant