Support JCache 1.1.0 #2212
Merged
Support JCache 1.1.0 #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljacomet
changed the title
chrisdennis
requested changes
Dec 13, 2017
107/build.gradle
Outdated
| @@ -32,8 +32,8 @@ sourceSets { | |||
| dependencies { | |||
| compile project(':impl'), project(':xml') | |||
| provided "javax.cache:cache-api:$parent.jcacheVersion" | |||
| tckTestRuntime 'javax.cache:cache-tests:1.0.1' | |||
| tckTestClasses('javax.cache:cache-tests:1.0.1:tests') { | |||
| tckTestRuntime "j«avax.cache:cache-tests:$jcacheTckVersion" | |||
| @@ -79,9 +79,6 @@ public void testRunTimeTypeSafety() throws Exception { | |||
|
|
|||
| try { | |||
| cacheManager.getCache("cache1"); | |||
| fail("Caches with runtime types should throw illegal argument exception when different types are used in getcache"); | |||
There was a problem hiding this comment.
This seems really broken... am I missing something here?
There was a problem hiding this comment.
See jsr107/jsr107spec#340 for the details behind this change. It effectively covers up a hole in the API.
ljacomet
force-pushed
the
jcache-1.1
branch
2 times, most recently
from
de1ee86 to
fa21244
Compare
henri-tremblay
approved these changes
Dec 21, 2017
chrisdennis
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to be ready for JCache 1.1 when it gets released as supporting it for Ehcache 3.5 would be ideal.
PR should fail to build until we can reference a released version though.