Upgrade to Gradle 4.6 #2348
Upgrade to Gradle 4.6 #2348
Conversation
demos/build.gradle
Outdated
| @@ -1,10 +1,16 @@ | |||
| plugins { | |||
| id 'org.akhikhl.gretty' version '2.0.0' apply false | |||
| buildscript { | |||
There was a problem hiding this comment.
For me, this is supposed to be legacy style. No?
There was a problem hiding this comment.
Yes... but something odd is happening if I try and do this any other way. Not sure if I'm screwing up, or if something is wrong with the way the forked version of the plugin is being published.
There was a problem hiding this comment.
When going back to the 2.0.0 version it "works" (jacoco plugin is failing). But I can't start the app with the new version when doing ../../gradlew appStart
There was a problem hiding this comment.
It's not Jacoco thats broken, it's Jacoco trying to interact with the gretty task. Gretty uses internal gradle APIs that changed in 4.6 and had to updated things. The broken appStart is an oversight, need to make sure the submodules can resolve the runner. Fixing.
There was a problem hiding this comment.
Seems I tripping on akhikhl/gretty#425
There was a problem hiding this comment.
Replacing the whole buildscript with
plugins {
id 'org.gretty' version '2.1.0' apply false
}
seems to work fine.
Including launching the demos with appStart.
There was a problem hiding this comment.
Right it does today: https://plugins.gradle.org/plugin/org.gretty
Version 2.1.0 (latest)
Created 20 March 2018.
I'll update accordingly.
There was a problem hiding this comment.
ah did not pay attention to the dates (PR or plugin publication) :-)
There was a problem hiding this comment.
héhé... yes... because I tried that earlier. It wasn't working because of a missing jetty 9...
chrisdennis
force-pushed
the
gradle-4.6
branch
2 times, most recently
from
adcbde8 to
2667faa
Compare
| } | ||
|
|
||
| subprojects { | ||
| apply plugin: 'war' | ||
| apply plugin: 'org.akhikhl.gretty' | ||
| apply plugin: 'org.gretty' |
There was a problem hiding this comment.
So far, without adding jcenter, I can't find the gretty jetty9 jar. So it's not working for me.
This is working:
subprojects {
apply plugin: 'war'
apply plugin: 'org.gretty'
repositories {
jcenter()
}
gretty {
httpPort = 8080
contextPath = '/'
servletContainer = 'jetty9'
}
dependencies {
compile 'javax.servlet:javax.servlet-api:3.1.0', project(':impl')
runtime 'ch.qos.logback:logback-classic:1.2.3', 'com.h2database:h2:1.4.196'
}
}
No description provided.