Lambda reconstruction in ZDC #1731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate collection for single-neutron recon in ZDC
added single-neutron reconstruction back in (under "stand alone").
for more information, see https://pre-commit.ci
separate collection for single-neutron recon in ZDC
added single-neutron reconstruction back in (under "stand alone").
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: calorimetry
Capybara summary for PR 1731
|
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
veprbl
reviewed
Feb 11, 2025
<math.h> to <cmath>
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
veprbl
reviewed
Feb 20, 2025
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
for more information, see https://pre-commit.ci
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@wdconinc @veprbl @ruse-traveler , thanks for the feedback. If you are satisfied, I would like to get this pull request finished so that I can follow through with a pull request on detector_benchmarks which is dependent on these changes. |
| @@ -5,6 +5,7 @@ | |||
| #include <edm4eic/MCRecoParticleAssociationCollection.h> | |||
| #include <edm4eic/ReconstructedParticleCollection.h> | |||
| #include <edm4hep/MCParticleCollection.h> | |||
| #include <edm4hep/Vector3f.h> | |||
There was a problem hiding this comment.
Hmmm... This might need another rebase...
There was a problem hiding this comment.
Iwyu told me to make this change if I remember correctly
Co-authored-by: Derek M Anderson <[email protected]>
Co-authored-by: Derek M Anderson <[email protected]>
Co-authored-by: Derek M Anderson <[email protected]>
Co-authored-by: Derek M Anderson <[email protected]>
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sebouh137
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Reconstruction of Lambda baryons using the ZDC. Also includes functionality to reconstruction photons and neutrons in the ZDC and distinguish between them.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
Yes. Adds two new algorithms (one for photon and neutron recon in the ZDC, and a second to find/fit lambda candidates from these particles).