feat(node-wasm, types)!: Add method to get blobs for wasm #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
reviewed
Nov 28, 2024
|
|
||
| #[cfg(not(feature = "wasm-bindgen"))] | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)] | ||
| pub struct Commitment { |
There was a problem hiding this comment.
cfg_attr doesn't work in this case?
There was a problem hiding this comment.
I did not find a way for this to work with just cfg_attr, I believe we're hitting rustwasm/wasm-bindgen#2703 here. (This could be resolved by cfg_eval sabilisation)
fl0rek
force-pushed
the
feat/blob_service
branch
from
a09db41
to
121e02d
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
from
121e02d
to
a8a1b20
Compare
fl0rek
changed the title
fl0rek
force-pushed
the
feat/blob_service
branch
from
aae8355
to
795e6ac
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
2 times, most recently
from
f3e5b98
to
93514f2
Compare
fl0rek
force-pushed
the
feat/blob_service
branch
from
93514f2
to
bcfefca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.