-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support 512 & 1GiB with huge refactors #717
Conversation
Blocked on #719 |
ab92ed4
to
4c70aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Not a fan of the macro but I get it
- Would've prefered if you had solved the randomness issue in a separate PR
But I can't argue that it makes sense to me. So far, we've added FC supported (even if unofficially) sizes, it will be interesting if and when trying sizes like 2GiB
Leaving as comment for now for discussion
good stuff man, the new macro in the proofs module is much clearer now. One suggestion: can we make the generic parameters even more explicit by using syntax like you also mention that generating the parent cache, precommit, and prove commit take a very long time (16, 31, and 15 minutes, respectively). Do we have plans to optimize or cache these steps further? It might be helpful to add some discussion on future work or known performance limitations in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment above but generally lgtm
@pete-eiger that's what is does now: https://github.com/eigerco/polka-storage/pull/717/files#diff-358758f32b7b2a1a8319e10e612480d4626364d9b4a520f311ca83d3a964075dR312-R324 |
ff3dcf2
to
0d8c25e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💪
Description
It adds support for 512MiB & 1 GiB sector sizes.
Required significant refactors, because of the underlying code for proof generation is generic.
Needed to write some macros to make the code more readable, they're not the best though.
Fixes #716.
Note 1: it took 16 minutes to generate parent cache:
Precommit took 31 mins. Prove Commit another 15 minutes.
Whole maat real_world test takes around 50minutes.
Params:
Checklist