Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial CI workflow #12

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Initial CI workflow #12

merged 3 commits into from
Jul 24, 2024

Conversation

pantrif
Copy link
Contributor

@pantrif pantrif commented Jul 23, 2024

Part of this #10

  • Adds pre-commit hook for running golangci-lint
  • Adds makefile for running tests and linter
  • Adds initial github checks (lint & tests)

@pantrif pantrif force-pushed the initial-ci-workflow branch 2 times, most recently from e1c94c7 to 5cc9dfb Compare July 23, 2024 13:28
carlos-romano
carlos-romano previously approved these changes Jul 23, 2024
Copy link
Contributor

@carlos-romano carlos-romano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aranw
aranw previously approved these changes Jul 23, 2024
Copy link

@aranw aranw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good one minor optional change there's a newer version of actions/setup-go available

.github/workflows/go-ci.yml Outdated Show resolved Hide resolved
@pantrif pantrif dismissed stale reviews from aranw and carlos-romano via 95491ba July 23, 2024 14:11
aranw
aranw previously approved these changes Jul 23, 2024
bamzedev
bamzedev previously approved these changes Jul 23, 2024
@pantrif pantrif dismissed stale reviews from bamzedev and aranw via fa64517 July 23, 2024 14:30
@pantrif pantrif force-pushed the initial-ci-workflow branch from 95491ba to fa64517 Compare July 23, 2024 14:30
bamzedev
bamzedev previously approved these changes Jul 23, 2024
bamzedev
bamzedev previously approved these changes Jul 23, 2024
@danielvladco
Copy link
Member

Don't forget to add the new lines at the end of files, also should we also add here the gorelease?

@pantrif
Copy link
Contributor Author

pantrif commented Jul 24, 2024

Don't forget to add the new lines at the end of files, also should we also add here the gorelease?

Added a newline at the end! I suggest creating a separate PR for the build/release (after discussing with the team first).

@pantrif pantrif merged commit 30fb858 into main Jul 24, 2024
2 checks passed
@pantrif pantrif deleted the initial-ci-workflow branch July 24, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants