Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add byte slice/array & bool serialization #45

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add byte slice/array & bool serialization #45

merged 1 commit into from
Aug 21, 2024

Conversation

pantrif
Copy link
Contributor

@pantrif pantrif commented Aug 16, 2024 •
edited
Loading

This PR adds serialization logic for the following types:

  • Adds length discriminator when encoding slices/array of bytes (C.1.4)
  • Single boolean serialization (3.7.3)

Part of this: #6

@pantrif pantrif requested a review from a team August 19, 2024 08:41
@pantrif pantrif changed the title Add byte slice/array serialization Add byte slice/array & bool serialization Aug 19, 2024
bamzedev
bamzedev reviewed Aug 21, 2024
View reviewed changes
pkg/serialization/codec/jam_codec.go Outdated Show resolved Hide resolved
pkg/serialization/codec/jam_codec.go Outdated Show resolved Hide resolved
pkg/serialization/codec/jam_codec.go Outdated Show resolved Hide resolved
pkg/serialization/codec/jam_codec.go Outdated Show resolved Hide resolved
@pantrif pantrif requested a review from bamzedev August 21, 2024 06:45
bamzedev
bamzedev previously approved these changes Aug 21, 2024
View reviewed changes
aranw
aranw previously approved these changes Aug 21, 2024
View reviewed changes
@pantrif pantrif dismissed stale reviews from aranw and bamzedev via 14f4390 August 21, 2024 09:39
@pantrif pantrif force-pushed the feat/sequence-encoding branch from c448c95 to 14f4390 Compare August 21, 2024 09:39
@pantrif pantrif merged commit a5447cf into main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamzedev bamzedev bamzedev approved these changes

@aranw aranw aranw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pantrif @aranw @bamzedev