feature: add i18n #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashachabin
force-pushed
the
feature-i18n
branch
5 times, most recently
from
d819afd to
a3dd970
Compare
sashachabin
force-pushed
the
feature-i18n
branch
from
a3dd970 to
fc804e1
Compare
sashachabin
force-pushed
the
feature-i18n
branch
from
fc804e1 to
1988fb7
Compare
sashachabin
reviewed
Apr 5, 2023
| } | ||
|
|
||
| // TODO: translate to english | ||
| export function MainText({ projects, team }: MainTextProps) { |
There was a problem hiding this comment.
my rebase updates:
I renamed <Page> to <MainText>.
It seems to be a more appropriate name
sashachabin
reviewed
Apr 5, 2023
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "Dev": { | |||
There was a problem hiding this comment.
my rebase updates:
I have saved these texts. But they have changed and are not used yet:
- "Write to us"
- "Congratulations"
- "Details"
- "Description"
sashachabin
reviewed
Apr 5, 2023
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
my rebase updates:
I haven't updated these texts
sashachabin
reviewed
Apr 5, 2023
Comment on lines
+33
to
+34
| projects={<Iframe src="https://projects.ekaterinburg.dev/widget" />} | ||
| team={<Team />} |
There was a problem hiding this comment.
my rebase updates:
I give <Team> amd <Iframe> as props. But if you want, we can delete <MainPage>
Open
sashachabin
force-pushed
the
main
branch
4 times, most recently
from
70d1354 to
cc5a8b4
Compare
sashachabin
force-pushed
the
main
branch
3 times, most recently
from
2288779 to
713a270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.