Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant 'typecheck' linter #8298

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Remove redundant 'typecheck' linter #8298

merged 1 commit into from
Mar 31, 2025

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 13, 2025 •
edited by cheeseandcereal
Loading

Description

This PR removes redundant typecheck from the linters.enable list.

typecheck is not a linter and it doesn't perform any analysis. It's just a way to identify, parse, and display compiling errors and some linter errors.

More info:

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added the area/tech-debt Leftover improvements in code, testing and building label Mar 31, 2025
cheeseandcereal
cheeseandcereal approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@cheeseandcereal cheeseandcereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cheeseandcereal cheeseandcereal merged commit e51e7e0 into eksctl-io:main Mar 31, 2025
11 of 12 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Mar 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheeseandcereal cheeseandcereal cheeseandcereal approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @cheeseandcereal